Skip to content

Example and linter updates#38

Merged
lickel merged 2 commits into
array-associationsfrom
array-associations-linter
May 9, 2022
Merged

Example and linter updates#38
lickel merged 2 commits into
array-associationsfrom
array-associations-linter

Conversation

@lickel

@lickel lickel commented May 9, 2022

Copy link
Copy Markdown
Collaborator

This updates the example project to use a Codable object, since that is going to be far more useful for someone new.
Further, I synchronized the linter rules with our internal configuration and ran swiftformat.

Note: I have not made swiftformat auto-run anywhere at the moment.

@codecov-commenter

codecov-commenter commented May 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #38 (29c03a2) into array-associations (51e81a9) will decrease coverage by 0.03%.
The diff coverage is 83.67%.

@@                  Coverage Diff                   @@
##           array-associations      #38      +/-   ##
======================================================
- Coverage               90.87%   90.84%   -0.04%     
======================================================
  Files                      30       30              
  Lines                    4922     4924       +2     
======================================================
  Hits                     4473     4473              
- Misses                    449      451       +2     
Impacted Files Coverage Δ
...s/Sources/Requests/PaginatingFetchDefinition.swift 91.66% <ø> (ø)
...ibleSectionsFetchedResultsControllerTestCase.swift 99.15% <ø> (ø)
...Controllers/FetchedResultsControllerTestCase.swift 100.00% <ø> (ø)
FetchRequests/Tests/TestObject.swift 89.47% <ø> (ø)
.../Controller/FetchedResultsControllerProtocol.swift 81.31% <33.33%> (ø)
...Sources/Associations/FetchRequestAssociation.swift 76.44% <50.00%> (-0.17%) ⬇️
.../Sources/Controller/FetchedResultsController.swift 81.15% <66.66%> (ø)
.../CollapsibleSectionsFetchedResultsController.swift 86.85% <75.00%> (-0.41%) ⬇️
...tchRequests/Sources/SwiftUI/FetchableRequest.swift 88.05% <83.33%> (ø)
FetchRequests/Sources/BoxedJSON.swift 79.48% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e81a9...29c03a2. Read the comment docs.

@lickel
lickel merged commit 73651b6 into array-associations May 9, 2022
@lickel
lickel deleted the array-associations-linter branch May 9, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants