Fix: EU region URL change for NinjaOne plugin#77
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated the NinjaOne plugin's EU region API base URL value from https://eu-api.ninjarmm.com to https://eu.ninjarmm.com in ui.json, and incremented the plugin version from 1.1.12 to 1.1.13 in metadata.json. ChangesNinjaOne EU URL and version update
Compact metadata
🐰 A tiny fix, a version bump too, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧩 Plugin PR Summary📦 Modified Plugins
📋 Results
🔍 Validation Details✅
|
| "help": "Select your NinjaOne instance region", | ||
| "defaultValue": "https://ca-api.ninjarmm.com", | ||
| "options": [ | ||
| { |
There was a problem hiding this comment.
Hard to pin this down but a few sources list these as:
US: https://app.ninjarmm.com
US2: https://us2.ninjarmm.com
EU: https://eu.ninjarmm.com
CA: https://ca.ninjarmm.com
OC: https://oc.ninjarmm.com
Are we sure the others are correct? Defer to your call here as you've worked with this API a lot more than I have but just wanted to double check.
📋 Summary
Quite a simple region change for the EU region for the NinjaOne plugin. This does not break existing EU region customers as the new/changed URL resolves to the same API. This change is needed though as some NinjaOne customers do require eu.ninjarmm.com. The existing eu-api.ninjarmm.com URL that the plugin uses is an alias that seemingly not all customers can use.
🔗 Related issue(s)
https://squaredup-eng.atlassian.net/browse/PLUG-4662
🧩 Plugin details
Does this PR introduce any breaking changes?
If yes, describe:
📚 Documentation
✅ Checklist
Summary by CodeRabbit