Skip to content

Fix: EU region URL change for NinjaOne plugin#77

Open
Deenk wants to merge 1 commit into
mainfrom
fix-ninjaone-eu-region
Open

Fix: EU region URL change for NinjaOne plugin#77
Deenk wants to merge 1 commit into
mainfrom
fix-ninjaone-eu-region

Conversation

@Deenk

@Deenk Deenk commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

Quite a simple region change for the EU region for the NinjaOne plugin. This does not break existing EU region customers as the new/changed URL resolves to the same API. This change is needed though as some NinjaOne customers do require eu.ninjarmm.com. The existing eu-api.ninjarmm.com URL that the plugin uses is an alias that seemingly not all customers can use.


🔗 Related issue(s)

https://squaredup-eng.atlassian.net/browse/PLUG-4662


🧩 Plugin details

  • Plugin name:
  • Type of change:
    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe):

⚠️ Breaking changes

Does this PR introduce any breaking changes?

  • No
  • Yes (please describe):

If yes, describe:

  • What breaks
  • Who is impacted
  • Any migration steps

📚 Documentation

  • Documentation updated
  • No documentation changes needed

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the NinjaOne EU API base URL to use the updated endpoint.
  • Chores
    • Bumped the NinjaOne plugin version to 1.1.13.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d3bb5ffa-9818-4072-bc2e-643ed5053a1e

📥 Commits

Reviewing files that changed from the base of the PR and between 05aeeab and 3717b12.

📒 Files selected for processing (2)
  • plugins/NinjaOne/v1/metadata.json
  • plugins/NinjaOne/v1/ui.json

📝 Walkthrough

Walkthrough

Updated the NinjaOne plugin's EU region API base URL value from https://eu-api.ninjarmm.com to https://eu.ninjarmm.com in ui.json, and incremented the plugin version from 1.1.12 to 1.1.13 in metadata.json.

Changes

NinjaOne EU URL and version update

Layer / File(s) Summary
EU URL correction and version bump
plugins/NinjaOne/v1/ui.json, plugins/NinjaOne/v1/metadata.json
The EU apiBaseUrl option value is corrected to https://eu.ninjarmm.com, and the plugin version is bumped to 1.1.13.

Compact metadata

  • Related issues: None found
  • Related PRs: None found
  • Suggested labels: None found
  • Suggested reviewers: None found

🐰 A tiny fix, a version bump too,
EU's address now rings true,
No more "-api" in the way,
Ninja hops off to save the day! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the NinjaOne EU region URL update.
Description check ✅ Passed The description is mostly complete, covering the summary, issue, change type, breaking changes, docs, and checklist, though the plugin name field is blank.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/NinjaOne/v1

📋 Results

Step Status
Validation ✅ Passed
Deployment 🚀 Deployed

🔍 Validation Details

ninja-one
{
  "valid": true,
  "pluginName": "ninja-one",
  "pluginType": "cloud",
  "summary": {
    "Data Streams": 37,
    "Import Definitions": 1,
    "UI Configuration": true,
    "Has Icon": true,
    "Has Default Content": true,
    "Config Validation": true,
    "Custom Types": true
  }
}

@Deenk Deenk marked this pull request as ready for review July 1, 2026 09:36
@Deenk Deenk requested a review from a team July 1, 2026 09:36
@Deenk Deenk changed the title fix eu region for customer Fix: EU region URL change for NinjaOne plugin Jul 1, 2026
"help": "Select your NinjaOne instance region",
"defaultValue": "https://ca-api.ninjarmm.com",
"options": [
{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to pin this down but a few sources list these as:

US: https://app.ninjarmm.com
US2: https://us2.ninjarmm.com
EU: https://eu.ninjarmm.com
CA: https://ca.ninjarmm.com
OC: https://oc.ninjarmm.com

Are we sure the others are correct? Defer to your call here as you've worked with this API a lot more than I have but just wanted to double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants