[go-borges] Use go-borges to access repositories#888
Merged
Conversation
golangcibot
reviewed
Jun 19, 2019
golangcibot
reviewed
Jun 20, 2019
erizocosmico
approved these changes
Jun 20, 2019
Contributor
|
Other than GolangCI stuff, if CI passes, LGTM |
jfontan
force-pushed
the
go-borges-rebase
branch
from
June 20, 2019 08:29
bdefd6a to
93bde04
Compare
Checksum: Now repositories are not returned in an specific order. Checksum is calculated per repository and ordered before calculating the final one. Signed-off-by: Javi Fontan <jfontan@gmail.com>
Global format can be specified with --format, --bare, --bucket and
--rooted. To mix directories the format can be specified as a file URL:
-d file:///path/to/library?format=siva&bucket=4&rooted=false
Also:
* Updated builder container to go 1.12
* Added SIVA env to docker init.sh to configure gitbase to use siva
library
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Fixed documentation, typos and erroneous messages. Also library URL parameters are converted to lowercase before parsing. Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Also fix some repositories left open. Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
Signed-off-by: Javi Fontan <jfontan@gmail.com>
jfontan
force-pushed
the
go-borges-rebase
branch
from
June 20, 2019 08:51
93bde04 to
044094c
Compare
Contributor
Author
|
Rebased with latest changes in |
mcarmonaa
approved these changes
Jun 20, 2019
Contributor
ajnavarro
approved these changes
Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: These are the changes from branch
go-borges-integrationrebased with the latest version in master plus fixes to new tests.go-borgesstill does not support non rooted siva files (the ones generated by old borges). We are working on adding compatibility but all the changes for gitbase are done (even cli to support this). It may be better to release a final version of0.21.0and start a0.22.0-betawith these changes.make upgradecommand if applicable.