Revert "support backend hmr" - #302
Merged
Merged
Conversation
This reverts commit c14ceab.
Contributor
No worries! What’s your environment? I tried it on my side, and it seems to be working fine. |
Contributor
Author
|
Interesting.. I'm on mac OS 14.5 using iTerm. I can try again later but at the time I tried I gave it a few goes and rebuilt/redownloaded deps and it was still happening |
Contributor
It might be related to the dependencies between shared and api. I will keep working on it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #277
@swk777 after merge, i ran
pnpm devand it spins up the API server twice, the second one failing due to port in use. I'm going to revert until that's fixed. My apologies, I should have verified this before merging.