refactor(generate): route all setup-cli emissions through one emitter - #652
Merged
Conversation
Collapse the 15 scattered sites that print the setup-cli composite-action step into a single writeSetupCLIStep helper. Each generator keeps its own getCLIRef/GetCLIVersion resolution and passes the resolved values plus the token, input ordering, and optional step-level if guard. Generated output is byte-identical. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The generator emits the "Setup CLI" step (
uses: stablekernel/cascade/.github/actions/setup-cli@<ref>plus its inputs) from 16 scattered sites acrossinternal/generate/, with no shared emitter. A planned--cli-install=action|binaryflag (#651) needs one place to branch the install method; today it would have to touch every site.Fix
Route every setup-cli emission through one canonical emitter,
writeSetupCLIStepininternal/generate/setup_cli.go, driven by a smallsetupCLIStepdescriptor (ref,version,token,tokenBeforeVersion,ifExpr). Ref resolution stays with each caller, so behavior is unchanged. Output is byte-identical.Verification
go build ./...,go test ./...(3655 passed / 37 packages),go test -race ./internal/generate/,golangci-lint run ./...all clean.generate-workflow --own-repo): zero working-tree drift, confirming byte-identical generated output.cascade-reviewerpass: APPROVE, with its own drift regeneration.Prep for #651; no behavior change.