chore(deps): pin out TS7/ai-sdk-v4 majors, patch postcss + esbuild advisories - #87
Merged
Merged
Conversation
Dependabot's dev-dependencies group keeps opening PRs that cannot pass CI. TypeScript 7 breaks declaration emit: tsup bundles rollup-plugin-dts 6.x, whose peer range is "^4.5 || ^5.0 || ^6.0", and DTS build dies with "Cannot read properties of undefined (reading 'useCaseSensitiveFileNames')". No released tsup or rollup-plugin-dts supports TS7. @ai-sdk/provider v4 is a spec migration, not a bump: the provider implements LanguageModelV3* and declares peerDependencies ^3.0.0, so a v4 dev dependency would typecheck against types consumers never install. Both ignores are scoped to semver-major only; minor and patch updates still flow through the group.
Resolves the two open Dependabot alerts, both dev-only transitives: - postcss 8.5.15 -> 8.5.25 (GHSA-r28c-9q8g-f849, high): sourceMappingURL path traversal. Reached via vite; a lockfile refresh is enough since vite wants ^8.5.15 and tsup peers ^8.4.12. - esbuild 0.27.7 -> 0.28.1 (GHSA-g7r4-m6w7-qqqr, low): dev-server arbitrary file read on Windows. tsup pins ^0.27.0, so this needs an overrides entry to pull the patched minor. npm audit reports 0 vulnerabilities. npm run prepublishOnly passes: typecheck, 393 tests, ESM and DTS build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the loop on the failing dependabot dev-dependencies PR (#83) and the two open Dependabot alerts.
Why #83 could not merge
Its package.json diff was two majors. Reproduced on the PR branch: typecheck and tests pass, ESM build passes, then declaration emit dies.
rollup-plugin-dts6.x fordts: true, whose peer range istypescript: ^4.5 || ^5.0 || ^6.0. Under TS7 the DTS step throwsTypeError: Cannot read properties of undefined (reading 'useCaseSensitiveFileNames'). Installing onlytypescript@6.0.3back into that same tree makes the build green, so the failure isolates to TypeScript alone. No releasedtsup(8.5.1) orrollup-plugin-dts(6.4.1) supports TS7.LanguageModelV3types. The provider implements the V3 spec throughout and declarespeerDependencies: { "@ai-sdk/provider": "^3.0.0" }, so a v4 dev dependency typechecks against types consumers never install. That major is a deliberate spec migration, not a dependency bump.Changes
chore(deps): ignore typescript and @ai-sdk/provider majorsAdds an
ignoreblock to the npm entry in.github/dependabot.yml, scoped toversion-update:semver-majorfor both packages, each with a comment naming the concrete reason and the condition for removing it. Minor and patch updates keep flowing through the existing group.chore(deps): patch postcss and esbuild advisoriesBoth alerts are dev-only transitives:
postcss needed only a lockfile refresh: vite wants
^8.5.15and tsup peers^8.4.12, both satisfied by 8.5.25. esbuild needed anoverridesentry because tsup pins^0.27.0. The both-overrides variant was tested first and produced an identical tree, so the narrower one shipped.Lockfile churn is limited to esbuild plus its platform binaries, postcss, and nanoid 3.3.12 -> 3.3.16 (a postcss dependency). All
resolvedURLs remain registry.npmjs.org.Verification
npm run prepublishOnlyexits 0: typecheck, 393 tests, ESM and DTS build successnpm audit: 0 vulnerabilities, down from 1 high and 1 low