Skip to content

build: Update serde_yaml to 0.9.4 - #455

Closed
Pscheidl wants to merge 1 commit into
stackabletech:mainfrom
Pscheidl:2022-08-07-dep-update
Closed

build: Update serde_yaml to 0.9.4#455
Pscheidl wants to merge 1 commit into
stackabletech:mainfrom
Pscheidl:2022-08-07-dep-update

Conversation

@Pscheidl

@Pscheidl Pscheidl commented Aug 7, 2022

Copy link
Copy Markdown
Contributor

Description

The test_ser_inline had to be modified according to the new serialization style.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

The `test_ser_inline` had to be modified according to the new serialization style.
@Pscheidl
Pscheidl force-pushed the 2022-08-07-dep-update branch from b81a852 to c5fe43c Compare August 7, 2022 09:35
@nightkr

nightkr commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

Hi!

We already have a PR for updating to 0.9.x (#450), but we're currently blocked on disabling the new !EnumVariant syntax (which you ran into at https://github.com/stackabletech/operator-rs/pull/455/files#diff-f8e1b80e4d4c689e562ed1f25c1f2fdd39eb590c56e4214ae968d861e9415b6fR239), since that's not really consistent with how Kubernetes understands sum types/enums with values. We'd rather not end up emitting YAML in a format that kubectl isn't able to deserialize correctly.

Is sticking to serde_yaml 0.8.x (for now) blocking a use case for you?

@nightkr

nightkr commented Aug 8, 2022

Copy link
Copy Markdown
Contributor

I'm closing this PR for now since we can't really merge it as is, but the question above is still useful for reprioritizing #450.

@nightkr nightkr closed this Aug 8, 2022
@Pscheidl

Pscheidl commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

Definitely not a blocker. Thanks.

@Pscheidl
Pscheidl deleted the 2022-08-07-dep-update branch August 8, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants