feat(core): Extension mechanism#81
Merged
Merged
Conversation
JoseLion
force-pushed
the
feat/extension-mechanism
branch
from
November 23, 2022 22:57
69127d6 to
27dfb90
Compare
JoseLion
force-pushed
the
feat/extension-mechanism
branch
from
November 23, 2022 23:04
27dfb90 to
0747c09
Compare
JoseLion
marked this pull request as ready for review
November 25, 2022 23:00
alejo0o
approved these changes
Jan 30, 2023
alejo0o
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Awesome new feature 🤯 👍
Contributor
Author
|
@all-contributors please add @alejo0o for review |
Contributor
|
I've put up a pull request to add @alejo0o! 🎉 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an extension mechanism that allows users to add instances of
Assertion<T>to the logic within theexpect(..)function. These are added in the form of aPlugin<T, A extends Assertion<T>object, which contains the necessary information to determine where and when the instance is returned by theexpect(..)function.Additionally, the PR adds another example workspace called
@examples/symbol-plugin, which shows how a plugin can be created as a 3rd-party library. Then the plugin is used and tested in both@examples/jestand@examples/mochaworkspaces.