Conversation
MCPServer and MCPRemoteProxy workloads that rely on the global/ default Redis credentials without an explicit spec.sessionStorage connect without a password and crash-loop against authenticated Redis. Only VirtualMCPServer receives the default password today. Fixes #1160 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
reyortiz3
marked this pull request as draft
September 17, 2026 15:46
Contributor
Author
|
Holding as draft: stacklok/toolhive#6679 fixes the underlying operator bug this warning documents. Once that merges, ships in a toolhive release, and lands in a pinned Stacklok Enterprise Platform release, this warning should be removed rather than merged — reopening this PR then would just require an immediate revert. |
Contributor
Author
|
Closing without merging: stacklok/toolhive#6679 fixes the underlying bug before this warning would need to ship. See prior comment for context. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a warning to the "Global Redis/Valkey defaults" section explaining that the global/default Redis password is only forwarded to
VirtualMCPServerworkloads today.MCPServerandMCPRemoteProxyworkloads relying on the global default without an explicitspec.sessionStorageconnect to authenticated Redis without a password and crash-loop withNOAUTH Authentication required.Verified against the vendored ToolHive operator source in
stacklok-enterprise-platform(mcpserver_controller.go'sbuildRedisPasswordEnvVaronly injects the password for an explicitspec.sessionStorage.passwordRef), confirming this is still the current behavior.Type of change
Related issues/PRs
Fixes #1160
Related: stacklok/stacklok-enterprise-platform#4310
Screenshots
N/A (text-only warning admonition)
Submitter checklist
Content and formatting
Reviewer checklist
Content