Skip to content

feat(redis): add configurable connection pool bounds - #287

Merged
samuv merged 1 commit into
mainfrom
t3code/configurable-redis-pool-bounds
Sep 11, 2026
Merged

samuv merged 1 commit into
mainfrom
t3code/configurable-redis-pool-bounds

Conversation

@samuv

@samuv samuv commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add PoolSize and MaxActiveConns to redisconn.Config and the deprecated redis.Config facade
  • propagate both values to standalone, cluster, and Sentinel go-redis options
  • reject negative values while preserving go-redis defaults for zero values
  • keep both settings independent and document bounded-pool configuration

Testing

  • task
  • task license-check

Signed-off-by: Samuele Verzi <samu@stacklok.com>
@samuv samuv self-assigned this Sep 11, 2026
@samuv
samuv merged commit d983e47 into main Sep 11, 2026
6 checks passed
@samuv
samuv deleted the t3code/configurable-redis-pool-bounds branch September 11, 2026 14:13
reyortiz3 added a commit that referenced this pull request Sep 11, 2026
* Detect stale nested-module pins before release

validate-release.sh only checked that a required redisconn/*
tag existed, not that the pinned version still matches the
current tree. #287 changed redisconn's Config without bumping
its tag, so root releases v0.0.44-v0.0.46 shipped referencing
a stale, incompatible redisconn v0.0.1 via the module proxy.

Also wire test-validate-release.sh into CI; it previously ran
only through the local Taskfile.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* Drop dev-only replace directives in redisconn providers

Renovate already bumped the redisconn requirement in these
manifests to the released v0.0.2 (#293), which was the only
part of #292 not already applied; folding in the remaining
replace-directive removal here supersedes that PR.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* Revert "Drop dev-only replace directives in redisconn providers"

This reverts commit de2b2a0.

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants