fix(flatpak): add filesystem mapping for qoder client - #2646
Merged
Merged
Conversation
ToolHive v0.45.0 added Qoder IDE as a supported MCP client (stacklok/toolhive#5870). The Flatpak build runs `thv client register --help` at make time and fails if any reported client is missing from CLIENT_FLATPAK_PATHS. Map `qoder` to `~/.qoder`, matching the Linux config path declared upstream.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Flatpak filesystem permission mapping for the newly supported qoder MCP client (introduced in ToolHive v0.45.0) so the Flatpak build-time validation no longer fails when thv client register --help reports qoder.
Changes:
- Add
qoder→~/.qodertoCLIENT_FLATPAK_PATHS. - Extend the sample
thv client register --helpoutput in tests to includeqoder. - Add a regression unit test asserting
flatpakFilesystemEntries(['qoder'])yields--filesystem=~/.qoder.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| utils/flatpak-client-paths.ts | Adds the qoder filesystem mapping used to generate Flatpak --filesystem= permissions. |
| utils/tests/flatpak-client-paths.test.ts | Updates the help-output fixture and adds a regression test ensuring qoder maps to ~/.qoder. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kantord
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thv client register --helpat build time and fails if any reported client is missing fromCLIENT_FLATPAK_PATHS.qoderto~/.qoder, matching the Linux config path (~/.qoder/mcp.jsonand~/.qoder/skills/) declared upstream.chore(deps): update dependency stacklok/toolhive to v0.45.0).Test plan
utils/flatpak-client-paths.ts(11 passing), including a regression thatqodermaps to--filesystem=~/.qoderNo Flatpak filesystem path mapping for client "qoder"