Add POST /oauth/register handler for dynamic client registration - #3428
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3428 +/- ##
==========================================
- Coverage 64.94% 64.92% -0.03%
==========================================
Files 391 392 +1
Lines 38197 38359 +162
==========================================
+ Hits 24808 24903 +95
- Misses 11455 11509 +54
- Partials 1934 1947 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrobla
reviewed
Jan 26, 2026
yrobla
reviewed
Jan 26, 2026
yrobla
previously approved these changes
Jan 26, 2026
yrobla
left a comment
Contributor
There was a problem hiding this comment.
approved with some comments
Implement the registration endpoint already advertised in the OAuth discovery metadata. The handler validates requests via the registration package's allowlists, creates a public LoopbackClient, and persists it through the storage.ClientRegistry interface.
- Validate Content-Type header per RFC 7591 (must be application/json) - Add test case for oversized request body (64KB limit) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
tgrunnagle
previously approved these changes
Jan 26, 2026
jhrozek
force-pushed
the
auth-proxy-pr-10-4-handlers-dcr
branch
from
January 26, 2026 21:31
6f1f81f to
c6d7e32
Compare
Contributor
Author
|
@yrobla sorry for the delay in addressing the comments, I wrote the patches, replied to you but forgot to push the new code. |
yrobla
approved these changes
Jan 27, 2026
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the registration endpoint already advertised in the OAuth discovery metadata. The handler validates requests via the registration package's allowlists, creates a public LoopbackClient, and persists it through the storage.ClientRegistry interface.