DRAFT: Add network/client span attributes and fix span status per OTEL semconv - #3735
Closed
ChrisJBurns wants to merge 1 commit into
Closed
ChrisJBurns wants to merge 1 commit into
ChrisJBurns wants to merge 1 commit into
Conversation
8 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## otel/pr2a-attribute-rename #3735 +/- ##
==============================================================
+ Coverage 66.40% 66.41% +0.01%
==============================================================
Files 427 427
Lines 41860 41888 +28
==============================================================
+ Hits 27796 27822 +26
+ Misses 11953 11949 -4
- Partials 2111 2117 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisJBurns
force-pushed
the
otel/pr2a-attribute-rename
branch
from
February 10, 2026 14:25
329ed9e to
2aa273b
Compare
ChrisJBurns
requested review from
amirejaz,
eleftherias,
jhrozek,
lujunsan and
rdimitrov
as code owners
February 10, 2026 14:25
Add new additive span attributes: - network.protocol.name and network.protocol.version - client.address and client.port from RemoteAddr - mcp.session.id from Mcp-Session-Id header - error.type on 5xx errors Fix span status to follow OTEL semantic conventions: - 4xx responses now leave span status Unset (client errors) - 5xx responses set Error with error.type attribute - 2xx/3xx remain Ok Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ChrisJBurns
force-pushed
the
otel/pr2b-new-attributes
branch
from
February 10, 2026 14:26
956dd9e to
54bda5c
Compare
Collaborator
Author
|
Superseded by a new PR after rebasing onto the updated main branch (which now includes the feature-flag and attribute rename PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
network.protocol.name,network.protocol.version,client.address,client.port,mcp.session.iderror.typehttpProtocolVersionandparseRemoteAddrhelper functionsThese are new attributes that have no legacy equivalents — they are always emitted regardless of the
UseLegacyAttributessetting.Stacked on #3734 (attribute rename + dual emission).
Test plan
httpProtocolVersionhelper (HTTP/1.0, 1.1, 2.0, 3.0, zero)parseRemoteAddrhelper (host:port, IPv6, empty, no port)TestHTTPMiddleware_FinalizeSpan_Logicfor 4xx → Unset, 5xx → Error behaviortask lintpassestask testpasses🤖 Generated with Claude Code