Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/authserver/server/handlers/dcr.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ func (h *Handler) RegisterClientHandler(w http.ResponseWriter, req *http.Request
GrantTypes: validated.GrantTypes,
ResponseTypes: validated.ResponseTypes,
Scopes: h.config.ScopesSupported,
Audience: h.config.AllowedAudiences,
})
if err != nil {
logger.Errorw("failed to create client", "error", err)
Expand Down
7 changes: 6 additions & 1 deletion pkg/authserver/server/handlers/dcr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ func TestRegisterClientHandler_ClientIsStored(t *testing.T) {
return nil
})

handler := &Handler{storage: stor, config: &server.AuthorizationServerConfig{}}
allowedAudiences := []string{"https://mcp.example.com"}
handler := &Handler{storage: stor, config: &server.AuthorizationServerConfig{
AllowedAudiences: allowedAudiences,
}}

reqBody, err := json.Marshal(registration.DCRRequest{
RedirectURIs: []string{"http://127.0.0.1:8080/callback"},
Expand All @@ -155,4 +158,6 @@ func TestRegisterClientHandler_ClientIsStored(t *testing.T) {
assert.Equal(t, resp.ClientID, loopbackClient.GetID())
assert.True(t, loopbackClient.IsPublic())
assert.Equal(t, []string{"http://127.0.0.1:8080/callback"}, loopbackClient.GetRedirectURIs())
assert.Equal(t, fosite.Arguments(allowedAudiences), loopbackClient.GetAudience(),
"DCR client must inherit server's AllowedAudiences so refresh token requests with resource= succeed")
}
6 changes: 6 additions & 0 deletions pkg/authserver/server/registration/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ type Config struct {
// Scopes overrides the default scopes.
// If nil or empty, DefaultScopes is used.
Scopes []string

// Audience is the list of allowed audience values for this client.
// Per RFC 8707, the "resource" parameter in token requests is validated
// against this list. If nil, audience validation will reject all values.
Audience []string
}

// New creates a fosite.Client from the given configuration.
Expand Down Expand Up @@ -143,6 +148,7 @@ func New(cfg Config) (fosite.Client, error) {
ResponseTypes: responseTypes,
GrantTypes: grantTypes,
Scopes: scopes,
Audience: cfg.Audience,
Public: cfg.Public,
}

Expand Down
Loading