Skip to content

TEST: rename mcpgroups.spec.description → summary (do not merge) #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisJBurns wants to merge 1 commit into from
Closed

TEST: rename mcpgroups.spec.description → summary (do not merge) #4988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cmd/thv-operator/api/v1beta1/mcpgroup_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,13 @@ import (

// MCPGroupSpec defines the desired state of MCPGroup
type MCPGroupSpec struct {
// Description provides human-readable context
// Description provides human-readable context.
// TEST: JSON tag deliberately renamed from "description" to "summary" to
// validate that the api-compat.yml workflow flags the field rename as a
// breaking change. Go field name is kept so existing callers still
// compile. Do NOT merge this PR.
// +optional
Description string `json:"description,omitempty"`
Description string `json:"summary,omitempty"`
}

// MCPGroupStatus defines observed state
Expand Down
18 changes: 14 additions & 4 deletions deploy/charts/operator-crds/files/crds/toolhive.stacklok.dev_mcpgroups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,13 @@ spec:
spec:
description: MCPGroupSpec defines the desired state of MCPGroup
properties:
description:
description: Description provides human-readable context
summary:
description: |-
Description provides human-readable context.
TEST: JSON tag deliberately renamed from "description" to "summary" to
validate that the api-compat.yml workflow flags the field rename as a
breaking change. Go field name is kept so existing callers still
compile. Do NOT merge this PR.
type: string
type: object
status:
Expand Down Expand Up @@ -213,8 +218,13 @@ spec:
spec:
description: MCPGroupSpec defines the desired state of MCPGroup
properties:
description:
description: Description provides human-readable context
summary:
description: |-
Description provides human-readable context.
TEST: JSON tag deliberately renamed from "description" to "summary" to
validate that the api-compat.yml workflow flags the field rename as a
breaking change. Go field name is kept so existing callers still
compile. Do NOT merge this PR.
type: string
type: object
status:
Expand Down
18 changes: 14 additions & 4 deletions deploy/charts/operator-crds/templates/toolhive.stacklok.dev_mcpgroups.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,13 @@ spec:
spec:
description: MCPGroupSpec defines the desired state of MCPGroup
properties:
description:
description: Description provides human-readable context
summary:
description: |-
Description provides human-readable context.
TEST: JSON tag deliberately renamed from "description" to "summary" to
validate that the api-compat.yml workflow flags the field rename as a
breaking change. Go field name is kept so existing callers still
compile. Do NOT merge this PR.
type: string
type: object
status:
Expand Down Expand Up @@ -216,8 +221,13 @@ spec:
spec:
description: MCPGroupSpec defines the desired state of MCPGroup
properties:
description:
description: Description provides human-readable context
summary:
description: |-
Description provides human-readable context.
TEST: JSON tag deliberately renamed from "description" to "summary" to
validate that the api-compat.yml workflow flags the field rename as a
breaking change. Go field name is kept so existing callers still
compile. Do NOT merge this PR.
type: string
type: object
status:
Expand Down
Loading