Clarify lazy-mode deferred-login message - #5429
Merged
Merged
Conversation
The lazy setup message said the user would be "signed in automatically", which oversells it: the deferred login still opens a browser for the user to complete on the first gateway request. Reword to "signed in on the first request a configured tool makes to the LLM gateway" so the message accurately describes when (and that) login happens. Addresses review feedback on #5427. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jerm-dro
approved these changes
Jun 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5429 +/- ##
==========================================
- Coverage 68.86% 68.85% -0.02%
==========================================
Files 634 634
Lines 64437 64437
==========================================
- Hits 44377 44369 -8
- Misses 16782 16791 +9
+ Partials 3278 3277 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5427 addressing review feedback (comment).
The
thv llm setup --lazymessage told the user they'd be "signed in automatically the first time a configured tool accesses the LLM gateway". As @jerm-dro noted, "signed in automatically" isn't quite accurate — the deferred login still opens a browser for the user to complete on the first request. This rewords the message so it accurately describes when login happens.Before:
After:
Type of change
Test plan
task test) —pkg/llm,cmd/thv/apppass (updated the lazy-message assertion insetup_test.go)task buildpassesthv llm setup --lazyprints the reworded messageDoes this introduce a user-facing change?
Yes — the wording of the
thv llm setup --lazyinformational message changes. No behavior change.Generated with Claude Code