Skip to content

Fix stale pre-pulled image tag causing flaky E2E tests #5693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdimitrov merged 1 commit into from
Jul 1, 2026
Merged

Fix stale pre-pulled image tag causing flaky E2E tests #5693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ jobs:
run: |
# Pre-pull images used by E2E tests so that workload creation
# does not pay the image-pull cost inside the 60s API timeout.
docker pull ghcr.io/stackloklabs/osv-mcp/server:0.1.0 &
docker pull ghcr.io/stackloklabs/osv-mcp/server:0.1.3 &
docker pull ghcr.io/stackloklabs/gofetch/server:1.0.2 &
docker pull ghcr.io/stacklok/toolhive/egress-proxy:latest &
# yardstick is only needed for the vmcp test suite
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/api_clients_validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ var _ = Describe("Clients API Validation", Label("api", "api-clients", "clients"
}
}
return false
}, 60*time.Second, 2*time.Second).Should(BeTrue())
}, 90*time.Second, 2*time.Second).Should(BeTrue())

By("Attempting to register with an invalid client type")
invalidClientName := fmt.Sprintf("invalid-client-%d", time.Now().UnixNano())
Expand Down Expand Up @@ -115,7 +115,7 @@ var _ = Describe("Clients API Validation", Label("api", "api-clients", "clients"
}
}
return false
}, 60*time.Second, 2*time.Second).Should(BeTrue())
}, 90*time.Second, 2*time.Second).Should(BeTrue())

By("Attempting bulk register with invalid client types")
invalidClientName1 := fmt.Sprintf("invalid-bulk-1-%d", time.Now().UnixNano())
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/api_groups_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ var _ = Describe("Groups API", Label("api", "api-misc", "groups", "e2e"), func()
}
}
return false
}, 60*time.Second, 2*time.Second).Should(BeTrue(),
}, 90*time.Second, 2*time.Second).Should(BeTrue(),
"Workload should reach running state before deletion")

By("Deleting the group with workloads")
Expand Down
Loading