Use conformant Accept in dual-era e2e - #6123
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
30d7207 to
7246fe5
Compare
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
7246fe5 to
ac56ca5
Compare
|
Addressed the review nit in Verification:
|
|
CI follow-up: the one red job is
That package/test is outside this PR's touched e2e raw-client/dual-era Accept path. I reran the failing test and package locally against the PR branch:
So this looks like an unrelated CI flake/regression in auth discovery rather than a failure introduced by this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6123 +/- ##
==========================================
+ Coverage 77.81% 77.82% +0.01%
==========================================
Files 760 761 +1
Lines 73133 73182 +49
==========================================
+ Hits 56908 56956 +48
- Misses 16220 16221 +1
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Accept: application/json, text/event-streamheader that both MCP revisions require.WithStreamableAccept()to the vMCP dual-era bridge and concurrent-mixing specs so those proxy paths now run under conformant request headers.Fixes #6104
Type of change
Test plan
task test)task test-e2e)task lint-fix)Manual testing:
PATH=/usr/local/go/bin:/root/go/bin:$PATH go test ./test/e2e -run 'TestRawClientBuilders/no_Accept|TestRawClientSSEResponse'PATH=/usr/local/go/bin:/root/go/bin:$PATH go test -race ./test/e2e -run 'TestRawClientBuilders/no_Accept|TestRawClientSSEResponse'PATH=/usr/local/go/bin:/root/go/bin:$PATH task buildPATH=/usr/local/go/bin:/root/go/bin:$PATH THV_BINARY=$PWD/bin/thv TOOLHIVE_DEV=true TEST_TIMEOUT=15m LABEL_FILTER='vmcp && dual-era' ./test/e2e/run_tests.sh— 7 passed, 0 failed, 500 skippedPATH=/usr/local/go/bin:/root/go/bin:$PATH task lintgit diff --checkNote: I also tried
go test ./test/e2ebefore exportingTHV_BINARY; it failed because the full e2e suite could not findthvon$PATH. The labeled e2e run above used the freshly builtbin/thvand passed.API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.Changes
test/e2e/vmcp_dual_era_test.gotest/e2e/dual_era_mixing_test.gotest/e2e/mcp_raw_client.gotest/e2e/mcp_raw_client_test.goDoes this introduce a user-facing change?
No.
Special notes for reviewers
The production behavior is unchanged. This only flips test traffic to the spec-required Accept header now that RawMCPClient can parse SSE-framed POST responses.