test: cover OIDC upstream allowPrivateIPs in BuildAuthServerRunConfig - #6288
Conversation
5c70f27 to
9f8ffe6
Compare
|
Updated the branch. Since #6320 added |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6288 +/- ##
==========================================
+ Coverage 78.01% 78.06% +0.04%
==========================================
Files 767 767
Lines 74273 74273
==========================================
+ Hits 57947 57981 +34
+ Misses 16321 16287 -34
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9f8ffe6 to
7a54ea0
Compare
|
huh for some reason CI doesn't kick in? |
The operator CRD's OIDC upstream config gained allowPrivateIPs in stacklok#6428, which also wired it through buildOIDCUpstreamRunConfig, so the capability this branch originally added now exists upstream. stacklok#6428's own tests cover only the OAuth2 side (TestBuildOAuth2UpstreamRunConfig_TransportOptions), leaving the OIDC-side mapping without direct regression coverage. Add a default-false assertion on the existing OIDC-upstream test case and an end-to-end test that exercises both OIDCUpstreamConfig.AllowPrivateIPs and OAuth2UpstreamConfig.AllowPrivateIPs reaching their run configs through BuildAuthServerRunConfig. This closes the coverage half of the stacklok#4523 ask; the field itself shipped via stacklok#6428. Signed-off-by: Aleksandr Filippov <71711753+alex-feel@users.noreply.github.com>
7a54ea0 to
32f6cda
Compare
#6428 delivered what this PR originally added:
allowPrivateIPsonOIDCUpstreamConfig, wired throughbuildOIDCUpstreamRunConfig. After a rebase onto current main, the field and all generated manifests are upstream's own, so this PR is now scoped to the piece #6428 did not include: direct regression coverage of the OIDC-side mapping.What it adds:
TestBuildAuthServerRunConfig;OIDCUpstreamConfig.AllowPrivateIPsandOAuth2UpstreamConfig.AllowPrivateIPsreaching their run configs throughBuildAuthServerRunConfig.This closes the coverage half of the #4523 ask; the capability itself shipped in v0.46.0.