Skip to content

Push skills unsigned until keyless signing lands - #6334

Merged
samuv merged 1 commit into
mainfrom
skills-ci/no-sign-push
Aug 14, 2026
Merged

samuv merged 1 commit into
mainfrom
skills-ci/no-sign-push

Conversation

@samuv

@samuv samuv commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The skills build/publish workflow has been failing on every push-enabled run since the skill-push signing requirement landed: pushing now requires either --key or --no-sign, and this workflow passed neither, so every push errors with signing key required.
  • Keyless push signing (Keyless OIDC push signing for thv skill push #6307) is in progress but not yet shipped (gated on a toolhive-core release), so as an interim fix, pass --no-sign to both thv skill push invocations to unblock CI. A TODO(#6307) marks where to switch to real signing once it lands.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Test plan

  • Reviewed the workflow diff manually; change is scoped to adding --no-sign to the two existing thv skill push calls, no other behavior changes.

Generated with Claude Code

Skill pushes now require either --key or --no-sign, so this
workflow has been failing every run since that check landed.
Keyless push signing (#6307) is in progress but not yet shipped,
so pass --no-sign as an interim measure to unblock CI.
@samuv
samuv requested a review from JAORMX as a code owner August 14, 2026 16:51
@github-actions github-actions Bot added the size/XS Extra small PR: < 100 lines changed label Aug 14, 2026
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.92%. Comparing base (8f294e2) to head (7b5d36f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6334      +/-   ##
==========================================
- Coverage   72.96%   72.92%   -0.05%     
==========================================
  Files         742      742              
  Lines       78236    78236              
==========================================
- Hits        57088    57053      -35     
- Misses      17168    17201      +33     
- Partials     3980     3982       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuv
samuv merged commit 8343851 into main Aug 14, 2026
45 checks passed
@samuv
samuv deleted the skills-ci/no-sign-push branch August 14, 2026 17:51
jhrozek pushed a commit to jhrozek/toolhive that referenced this pull request Aug 17, 2026
Skill pushes now require either --key or --no-sign, so this
workflow has been failing every run since that check landed.
Keyless push signing (stacklok#6307) is in progress but not yet shipped,
so pass --no-sign as an interim measure to unblock CI.
@github-actions github-actions Bot mentioned this pull request Aug 18, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants