Skip to content

fix(operator): add MCPGroup Proxies printer column - #6376

Merged
reyortiz3 merged 3 commits into
stacklok:mainfrom
RaviTharuma:fix/mcpgroup-proxies-column
Aug 20, 2026
Merged

reyortiz3 merged 3 commits into
stacklok:mainfrom
RaviTharuma:fix/mcpgroup-proxies-column

Conversation

@RaviTharuma

@RaviTharuma RaviTharuma commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Cross-links

Summary

kubectl get mcpgroup only printed status.serverCount, so a group that was
entirely MCPRemoteProxy members looked empty even when
status.remoteProxyCount was non-zero.

  • Add a Proxies printer column on .status.remoteProxyCount for both
    v1alpha1 and v1beta1
  • Leave SERVERS / serverCount meaning unchanged (do not fold proxies in)
  • Regenerate CRDs + Helm wrappers

This follows the direction on the issue: a new column, not a redefine of
serverCount.

Fixes #6342

Type of change

  • Bug fix
  • New feature
  • Refactoring (no behavior change)
  • Dependency update
  • Documentation
  • Other (describe):

Test plan

  • Regenerated CRDs with task operator-manifests and task crdref-gen
  • Confirmed toolhive.stacklok.dev_mcpgroups.yaml (files + templates)
    gained a Proxies column for v1alpha1 and v1beta1
  • CI unit / operator tests
  • After merge: kubectl get mcpgroup shows a Proxies column matching
    status.remoteProxyCount

API Compatibility

  • This PR does not break the v1beta1 API, OR the api-break-allowed label is applied and the migration guidance is described above.

Adding an optional printer column is display-only. No schema fields change.

Does this introduce a user-facing change?

Yes. kubectl get mcpgroup now shows a Proxies column from
status.remoteProxyCount.

Special notes for reviewers

Named Proxies (not MEMBERS) so MCPServers stay in SERVERS and each object
type stays visible on its own, as requested on #6342.

kubectl get mcpgroup only showed MCPServers, so groups that were
all remote proxies looked empty. Add a Proxies column on remoteProxyCount
without redefining serverCount.

Fixes stacklok#6342
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@RaviTharuma

Copy link
Copy Markdown
Contributor Author

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.74%. Comparing base (d278b33) to head (c23326c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6376      +/-   ##
==========================================
- Coverage   77.75%   77.74%   -0.01%     
==========================================
  Files         750      750              
  Lines       72601    72601              
==========================================
- Hits        56448    56445       -3     
- Misses      16148    16151       +3     
  Partials        5        5              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reyortiz3
reyortiz3 merged commit 96bdd55 into stacklok:main Aug 20, 2026
44 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 26, 2026
2 tasks
@RaviTharuma
RaviTharuma deleted the fix/mcpgroup-proxies-column branch September 24, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(operator): MCPGroup SERVERS printer column ignores remoteProxies

3 participants