Repository navigation
fix(operator): remove CRD shortNames that collide with the resource's own names - #6689
Merged
ChrisJBurns merged 1 commit intoSep 21, 2026
Merged
Conversation
… own names The API server rejects a shortName equal to the CRD's singular or plural, so the CRD installs with NamesAccepted=False and helm --wait never returns. mcpservers shipped shortName=mcpserver;mcpservers, and mcpgroups shortName=mcpgroup -- both their own singulars. Regenerated the CRDs. Fixes stacklok#6685 Signed-off-by: lights <115397533+lightsabit@users.noreply.github.com>
lightsabit
requested review from
ChrisJBurns,
JAORMX,
blkt,
jerm-dro,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
September 18, 2026 13:23
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6689 +/- ##
==========================================
- Coverage 79.18% 79.17% -0.01%
==========================================
Files 790 791 +1
Lines 79121 79518 +397
==========================================
+ Hits 62649 62959 +310
- Misses 16467 16554 +87
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ChrisJBurns
approved these changes
Sep 21, 2026
Collaborator
|
Many thanks for this @lightsabit !! |
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.49.0 mcpservers CRD ships shortNames [mcpserver, mcpservers], both equal to the CRD's own singular/plural, so it installs with NamesAccepted=False and helm --wait hangs on it (#6685).
Sweeping the other CRDs found the same problem on mcpgroups, which ships shortName mcpgroup -- its own singular. This drops the colliding entries (keeping mcpg) and regenerates via
task operator-manifests, so both CRDs install clean.Hit this on a live v0.49.0 upgrade; worked around it with a post-renderer until now.