Repository navigation
Align Choice validation and prepare initial release - #5
Merged
Merged
Conversation
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Official contract cross-check
Rechecked https://api.typesafe.ai/openapi.json and https://docs.typesafe.ai/api plus the official retry documentation. ChoiceAnswer explicitly requires the highest-probability option. Usage nonnegativity is semantic token-count validation, not an OpenAPI minimum. Numeric tolerances remain unspecified. Existing Score structural checks are retained.
Verification
Offline unit tests, race tests, vet, both 10-second fuzz smoke targets, and independent spec/security/DevEx/QA review passed. Tests cover ties, exact small differences, extra answers, nil responses, preserved usage, and empty labels. No live inference.
Stacked on #4, which depends on #3. Merge in that order and retarget bases as needed. No guardrails or delegated routing implementation is added to the SDK.