Skip to content

Findings 33: document address collision edge case with same refHash #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hazim-j merged 1 commit into from
Aug 4, 2025
Merged

Findings 33: document address collision edge case with same refHash #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/account/KeystoreAccountFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ contract KeystoreAccountFactory {
senderCreator = _entryPoint.senderCreator();
}

/**
* @dev refHash may not be unique for every account if the same initial
* UserConfiguration Merkle Tree is used. In this case a unique salt value
* must be used to avoid address collision.
*/
function createAccount(bytes32 refHash, uint256 salt) public returns (KeystoreAccount ret) {
require(msg.sender == address(senderCreator), NotFromSenderCreator());
address addr = getAddress(refHash, salt);
Expand Down