Auto Backup of wallet no longer functions?

[squidicuzz]

It is expected that each time the wallet starts, a backup of the wallet.dat or whatever loaded wallet is to be created. So it seems this auto-backup feature of the wallet is no longer functional in v3.4.0 of SCC Core and was not noticed before release.

Note; A backup will still be taken whenever a new wallet is created, this backup contains 1000 pregenerated keys (generally).

A patch has been added for the wallet backup function in #32 to force a backup when the wallet starts.

Additional debug added as well.

[grigzy28]

Found where it got broken.... wallet/wallet.cpp
function AutoBackupWallet got partially rewritten along with several other routines in walletdb.cpp and bdb.cpp.

The routine is working as it should EXCEPT it's not getting to the backup part of the routine which is the last step. It is "aborting" or "finishing" the verify process and then "exiting" the whole series of routines somewhere. I am not a good programmer but was able to trace it down that far.

[grigzy28]

Original Code

Modified Code

It does compile and load and create the backup as intended. Not sure if the result would be the same if it there was a corrupted or other error loading the wallet file.

[squidicuzz]

Found where it got broken.... wallet/wallet.cpp function AutoBackupWallet got partially rewritten along with several other routines in walletdb.cpp and bdb.cpp.

Right, but I have modified some of the code in those files in attempts to fix this issue. So those changes were me, just recently. I traced it down to around the some points as well though. Thank you for verifying this.

I will check more and test those modifications you pointed out. 👍

[grigzy28]

The original code is from the 3.4.0 official source code build b6fb60c and not the modified develop branch code with those changes you had made the other day. I decided to do that since you had made those other changes and didn't want to collide with your changes and not get a valid result.