Repository navigation
[ANCHOR-1296]: SEP-6 wallet PATCH, quote funding-method conflict & claimable-balance non-support - #2033
Merged
ceciliaromao merged 16 commits intoSep 30, 2026
Conversation
…able' of https://github.com/stellar/anchor-platform into feat/anchor-1296-sep6-patch-quote-claimable
amandagonsalves
approved these changes
Sep 30, 2026
ceciliaromao
deleted the
feat/anchor-1296-sep6-patch-quote-claimable
branch
September 30, 2026 20:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PATCH /sep6/transactions/{id}, the wallet-facing endpoint SEP-6 defines for answering apending_transaction_info_updaterequest. Without it, a SEP-6 transaction the business server puts into that status has no way out — the wallet had nothing to PATCH against.PATCH /transactionscall can no longer move a SEP-6 transaction intopending_transaction_info_updatewith an emptyrequired_info_updates, which would have stranded it the same way (mirrors the existing SEP-31 guard).deposit-exchange/withdraw-exchange'sfunding_methodmatches the SEP-38 quote's delivery method, and rejects the request with a 400 when it doesn't.Quote not found, asset/amount mismatch) that already worked but had no HTTP-level test, and for claimable-balance non-support (a wallet declaringclaimable_balances_supported=trueagainst an anchor that doesn't support it still gets a normal deposit).Context
test/anchor-1296-sep6-coverage, [ANCHOR-1296]: Close remaining SEP-6 coverage audit gaps #2031): the wallet PATCH, the quote funding-method conflict, and the claimable-balance non-support check..specs/features/sep6-patch-quote-claimable/(30 acceptance criteria, S6PQ-01..30).Testing
./gradlew test./gradlew spotlessCheck :core:test :platform:test./gradlew :essential-tests:test --tests "*Sep6Tests*"— run twice in a row (67/67 passing)./gradlew :essential-tests:test --tests "*Sep6PlatformApiTests*" --tests "*Sep38Tests*"— passing, except one pre-existing, order-dependent flake unrelated to this diff (see Known limitations)Documentation
PlatformTransactionData.fields: the values a SEP-6 wallet supplied throughPATCH /transactions/:id. Read-only — the deprecatedPATCH /transactionsnever reads it back.required_info_message/required_info_updatesthrough the Platform API (previously mapped for SEP-31 only).PATCH /transactionsthat would put a SEP-6 transaction intopending_transaction_info_updatewith nothing requested.deposit-exchange/withdraw-exchangenow reject afunding_methodthat conflicts with the referenced quote's delivery method.V36__sep6_add_fields.sql.Known limitations
OptimisticLockingFailureExceptionfrom the@Versionlock) instead of a mapped 400, the same exposure SEP-31's wallet PATCH already has. Not covered here — tracked as a follow-up decision, not part of this fix.Sep6PlatformApiTestsunrelated to this diff: shared KYC state on a hardcoded test account, reused across allPlatformApiTestssubclasses on a long-lived local stack. Root-caused via aJSONCompareMode.LENIENTassertion this diff's field additions can't affect; expected to be clean on CI's fresh containers.