Fail fast in tests when container reports unhealthy - #971
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fails fast when Docker marks the Stellar container unhealthy, avoiding indefinite CI waits.
Changes:
- Detects the
unhealthycontainer status. - Prints container logs and exits with failure immediately.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fnando
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the "Wait for container to be healthy" step in action.yml exit immediately with the container logs when docker reports the container as unhealthy, instead of only checking for "healthy" and looping forever otherwise.
Why
A recent CI run hung for ~40 minutes before being cancelled because the wait loop never reacted to docker's
unhealthystatus. Docker will initially show a state ofstarting, then after many failed checks eventually move the container tounhealthy. If a container ends up in unhealthy it is unlikely to recover in the test so it should fail then.