Skip to content

Add XOXNO Lending to the ecosystem catalog and skill cards - #132

Open
mihaieremia wants to merge 2 commits into
stellar:mainfrom
mihaieremia:xoxno-lending-skill
Open

mihaieremia wants to merge 2 commits into
stellar:mainfrom
mihaieremia:xoxno-lending-skill

Conversation

@mihaieremia

@mihaieremia mihaieremia commented Sep 14, 2026 •

Copy link
Copy Markdown

Adds XOXNO Lending, a lending protocol live on Stellar mainnet, to the ecosystem catalog and the skill cards.

  • standards/ecosystem.md: entry under Lending & Borrowing with the controller and swap-router entry points, docs, SDK and OpenAPI specs, and a pointer to the XOXNO agent skill.
  • site/src/data/skills.ts: ECOSYSTEM_CARDS entry for XOXNO/rs-lending-xlm skills/xoxno-lending/SKILL.md.
  • evals/scenarios/standards/04-lending-protocols.json: routing scenario for lending-protocol questions.

- standards/ecosystem.md: XOXNO Lending entry under Lending & Borrowing
  (controller and swap-router entry points, docs, typed SDK and OpenAPI
  specs, pointer to the XOXNO agent-skill router)
- site: ECOSYSTEM_CARDS entry pointing at
  XOXNO/rs-lending-xlm skills/xoxno-lending/SKILL.md
- evals: standards scenario covering lending-protocol routing
@mihaieremia
mihaieremia marked this pull request as ready for review September 15, 2026 13:24
Copilot AI balanced review requested due to automatic review settings September 15, 2026 13:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-15T13:27:27.010560Z 6647b16 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6647b16ebc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/standards/ecosystem.md Outdated
Comment thread skills/standards/ecosystem.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds XOXNO Lending to Stellar ecosystem documentation, skill cards, and lending-protocol evaluation coverage.

Changes:

  • Documents XOXNO’s architecture, APIs, contracts, and skill routing.
  • Adds the XOXNO community skill card.
  • Adds a lending-protocol routing scenario.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Summary
skills/standards/ecosystem.md Adds XOXNO Lending documentation. Findings: qualify the generic account id trigger (moderate, 1 vote) and label network-specific contracts (nit, 1 vote).
site/src/data/skills.ts Adds the XOXNO community skill card.
evals/scenarios/standards/04-lending-protocols.json Adds lending-protocol routing evaluation coverage.
Suppressed comments (2)

skills/standards/ecosystem.md:88

  • This entry says XOXNO is live on both mainnet and testnet, but the controller and swap-router addresses here have no network qualifier. Unlike the K2 section's explicit Mainnet contracts label, this makes it easy for a testnet integrator to copy the wrong IDs; please label these values and direct readers to the network-specific entries in addresses.md.
- **Entry point**: lending — `controller` `CAUCMIN5KSXEVZ7NMXR3LZATGD5EFIEUI5XWTFLYRO2R5OTXI22WE5JX` (not the pool). Swaps — aggregator router `CCVENFSVCBYDHVOACFZXMNNYVOZ3LKXPZYU5LUI4N7KTXOKRVYD7F3TR`. Hubs, spokes, listed markets, and every other address: [addresses.md](https://github.com/XOXNO/rs-lending-xlm/blob/main/skills/xoxno-lending/addresses.md), generated from `configs/networks.json` — re-check before hard-coding.

skills/standards/ecosystem.md:82

  • The bare phrase account id is not XOXNO-specific and appears in ordinary Stellar account/API questions, so this routing rule can make unrelated requests fetch the external lending skill. Remove this trigger or qualify it (for example, XOXNO account id or the exact account_id identifier).
**Load the skill** when the task mentions XOXNO Lending, `rs-lending-xlm`, hub/spoke, `HubAssetKey`, position NFT, account id, `multiply`, `flash_position` (vs `flash_loan`), `@xoxno/sdk-js` `stellar-lending`, `api.xoxno.com/stellar-lending`, or `stellar-swap.xoxno.com`. Fetch [skills/xoxno-lending/SKILL.md](https://github.com/ghraw/XOXNO/rs-lending-xlm/main/skills/xoxno-lending/SKILL.md) and follow its routing table.

Note

Copilot is running an experiment and ran this review at Lite.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

Thanks for this — the entry is unusually well sourced, and the address discipline ("re-check before hard-coding") is exactly right for a catalog entry. I verified the contract claims and they hold up. Both IDs are live on Stellar mainnet, and the deployed controller's wasm hash matches controller_wasm_hash in your own configs/networks.json exactly. @xoxno/sdk-js does export ./stellar-lending with type declarations, and the REST spec has 44 paths under /stellar-lending.

One process note: you are a member of the XOXNO org, and this adds XOXNO to the official skills/standards catalog. That listing decision belongs to a maintainer, not to me, so I am not merging it. @kaankacar will make the call.

Two content points are worth fixing while it waits. Codex and Copilot each raised them, and I confirmed both:

  1. The two contract IDs carry no network label. Your networks.json lists different testnet values (controller CCXRWJ6S..., aggregator CDNTWMWW...). Soroban contract IDs are network-specific, so a testnet reader can copy the wrong ID. Please mark these two as mainnet. The K2 section above uses a "Mainnet contracts" label for this.
  2. The trigger list includes bare account id and multiply. Both terms are common in ordinary Stellar and arithmetic questions, so they can route unrelated tasks to an external skill. Please use the exact account_id identifier, or qualify them with XOXNO.

One item I could not settle: the three xoxno.com doc links return 403 to any non-browser client, which looks like a Cloudflare challenge rather than a missing page. They may well be fine in a browser.

Drop generic "account id" and "multiply" from the catalog load
instruction so an ecosystem lookup does not fetch the XOXNO skill.
Label the controller and swap-router IDs as mainnet and send testnet
lookups to addresses.md. Update the lending eval and add a routing
control for those generic terms.
Copilot AI review requested due to automatic review settings September 15, 2026 13:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Note

Copilot is running an experiment and ran this review at Lite.

@kaankacar

Copy link
Copy Markdown
Contributor

🤖 Automated message from Kaan's Automated Triage Bot.

Thanks — both fixes landed exactly right, and the extra negative-control scenario is a genuinely nice touch.

I re-verified at 002b2ae:

  • The entry labels the two IDs mainnet. Both match the mainnet keys in your configs/networks.json.
  • addresses.md does carry the differing testnet controller CCXRWJ6S... and router CDNTWMWW..., so the new pointer resolves.
  • The trigger list drops bare account id and multiply. Only distinctive identifiers remain.
  • routing/04-generic-lending-terms.json is valid JSON and matches its sibling scenarios.
  • site-ci is green at this head: lint, lint:ts, check:ecosystem-links, test:ecosystem-links and build all pass.

The three xoxno.com doc links still return 403 to any non-browser client. That looks like a Cloudflare challenge rather than a missing page, so I record it as unsettled, not as a defect.

Nothing technical is open from my side. The listing decision stays with @kaankacar, because this adds XOXNO to the official skills/standards catalog and you belong to the XOXNO org. So I am not merging this.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants