Fix TailwindCSS v4 Vite build and compile assets - #211
Merged
Merged
Conversation
|
Hi @pawell67 this update break lines color in light theme with Nova 5.7.7 (displayed as dark instead of light). 
As Tailwind 4 remove class theme switch, we need to define For the moment, I roll back to 4.5.0 |
pawell67
added a commit
to pawell67/nova-command-runner
that referenced
this pull request
Jun 26, 2026
Two pre-existing failures inherited from stepanenko3#211, unrelated to the dark mode change but blocking this PR's checks: - Front lint: package.json has no "type": "module", so vite.config.js loads as CommonJS and `require()`-ing the ESM-only @tailwindcss/vite throws ERR_REQUIRE_ESM under the CI Node 20.10. Rename to vite.config.mjs so Vite loads it as ESM. Verified: build fails under Node 20 with .js, passes with .mjs. - PHP Lint (Pint): drop the superfluous `@return null|string` phpdoc on RunsArtisan::getArtisanRunByName() that duplicates the `: ?string` return type (no_superfluous_phpdoc_tags, phpdoc_trim). Verified passing with the repo's pint.json. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Vite production build which started failing after upgrading to TailwindCSS v4 because it was trying to use Tailwind directly as a PostCSS plugin instead of via the new '@tailwindcss/vite' plugin. Included the missing 'name' attribute in package.json and the newly compiled 'dist' frontend assets. This also resolves the 'useLocalization' Vue error encountered in Nova 5.