from message to player

[nonchris]

Now that chat messages know who sent them, I'd like to have a method to get a player by their name, otherwise the player name is relatively useless.

Alternatively the message could also know the id of the player, so that we can have the old route.

The last option would be that the user themselves has to create a mapping playername -> index, but this would be a pretty advanced thing to require for an educational library.

f3f6c83

[nonchris]

also while we're at it: a timestamp would be cool 👀

[thisryan]

I guess we should just change the player index to player name everywhere, since player names are unqiue.

[nonchris]

this would require to always enter a name if you want to fetch a player.
i like that we have the option to just do get_player() w/o any argument passed.

[nonchris]

*and you can iterate over all players by just doing a for i loop.

edit.: maybe just offer both?

[thisryan]

yeah im thinking about doing both but im not sure what the best way would be

[nonchris]

¯_(ツ)_/¯

[thisryan]

Okay so for now im just going to return the player index as well as the timestamp. I will come up with a solution for using a player name elsewhere at another time

[thisryan]

#9

[nonchris]

going to return the player index as well as the timestamp.

so we will have name and index?

[nonchris]

what is the sender name if the message came from some kind of system unlike a player (e.g. a plugin)?

[thisryan]

Currently only player chat messages are tracked

[thisryan]

This issue is fixed in #10