Issue 6. Add tootip - #41
Conversation
|
@nmqhoan thanks for the new pr. I will check this out over the weekend. But just out of curiousity, where is d3.tip used? I just did a cursory look through and couldn't find where it was being implemented. |
|
Hi @stormpython , |
|
@stormpython, thanks for reviewing the code. I removed the d3.tip.js and committed. |
| height: auto; | ||
| padding: 5px; | ||
| z-index: 150; | ||
| background-color: #d3d3d3; |
There was a problem hiding this comment.
I think this can be changed to match the style in Kibana, which is:
fadeout(@gray-darker, 7%);
gray-darker: #222222
| @@ -0,0 +1,52 @@ | |||
| var d3 = require("d3"); | |||
There was a problem hiding this comment.
I am guessing this file should be removed?
| var text = g.selectAll('text.title') | ||
| .data([data]); | ||
|
|
||
| text.exit().remove(); |
There was a problem hiding this comment.
why was the space here removed?
| var text = d3.select(this).selectAll('text.' + cssClass) | ||
| .data(data); | ||
|
|
||
| text.exit().remove(); |
There was a problem hiding this comment.
why was the space above removed?
| selection.each(function (data) { | ||
| events.listeners(listeners); | ||
|
|
||
| layout.attr({ |
There was a problem hiding this comment.
why was the space above removed?
|
|
||
| var title = d3.selectAll('text.title'); | ||
| var value = d[key]; | ||
| if(key.toUpperCase() === 'ROW') |
There was a problem hiding this comment.
there should be a space between if and (
There was a problem hiding this comment.
Same goes for the if statement below.
There was a problem hiding this comment.
They are also missing curly braces.
stormpython
left a comment
There was a problem hiding this comment.
Aside from a few syntax things, this pr looks good.
|
LGTM! @nmqhoan thanks for getting this in. |
We updated the code based on your indications in PR #38
close #6