Skip live blocks below LIB before one-block lookup - #70
Merged
Merged
Conversation
A redundant source re-sending the lowest final block kept below LIB made the hub walk the one-block store for a block the forkable then drops.
UlysseCorbeil
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hub's early return for old blocks compared against the lowest block kept in the forkdb, which sits `keepFinalBlocks` below LIB. With several live sources, a source re-sending the lowest kept block got past that check, failed `Linkable` (its parent is pruned), and made the hub list the one-block store before the forkable dropped the block anyway. On a relayer with 3 sources on a fast chain, this happened ~720 times per hour and logged `block not linkable after one-block lookup` each time.
The hub now compares against the forkdb LIB, through a new `Forkable.LIBNum`.