Alter UCP Commands to match param specs - #297
Merged
ericgan-stripe merged 5 commits intoSep 9, 2026
Merged
ericgan-stripe merged 5 commits into
ericgan-stripe merged 5 commits into
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
kreese-stripe
approved these changes
Sep 9, 2026
kreese-stripe
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, one non-blocking comment
| const availability = | ||
| product.availability ?? firstVariant?.availability?.status; | ||
| const networkId = product.profile_id ?? firstVariant?.profile_id; | ||
| const business = product.profile_id ?? firstVariant?.profile_id; |
Collaborator
There was a problem hiding this comment.
not blocking: since there aren't any prod users of this API/these commands today, wonder if we should also update the API response schema? So we don't have to do this translation on the "frontend". Theoretically users could eventually use not just the CLI but the SDK, which doesn't appear to have this translation
ericgan-stripe
merged commit Sep 9, 2026
8e0dc71
into
stripe:kreese/ucp-checkout-commands
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
link-cli ucp catalog search
link-cli ucp checkout create
link-cli ucp checkout complete