add better-auth integration - #329
Open
stevekaliski-stripe wants to merge 1 commit into
Open
stevekaliski-stripe wants to merge 1 commit into
stevekaliski-stripe wants to merge 1 commit into
Conversation
stevekaliski-stripe
force-pushed
the
stevekaliski-better-auth
branch
3 times, most recently
from
September 17, 2026 19:59
e328a56 to
d8a6a78
Compare
stevekaliski-stripe
marked this pull request as ready for review
September 17, 2026 20:00
stevekaliski-stripe
force-pushed
the
stevekaliski-better-auth
branch
2 times, most recently
from
September 17, 2026 20:23
4785492 to
5f67b2a
Compare
za098yytd-debug
approved these changes
Sep 17, 2026
bytaesu
reviewed
Sep 18, 2026
bytaesu
left a comment
There was a problem hiding this comment.
How about exposing 2 plugin APIs?
await authClient.link.connect({
callbackURL: "/settings",
});
await authClient.link.disconnect({
accountId,
});With current structure, connecting a Link wallet requires calling authClient.linkSocial(). The plugin could provide a clearer Link-specific API while reusing Better Auth existing OAuth flow internally.
link.connect()would be a thin wrapper aroundlinkSocial().link.disconnect()would be a dedicated endpoint that validates a fresh session, account ownership, and last-account protection, then revokes the Link refresh token and deletes the local account only after revocation succeeds.
https://docs.stripe.com/agentic-commerce/link-cli/oauth#revoke-access
stevekaliski-stripe
force-pushed
the
stevekaliski-better-auth
branch
4 times, most recently
from
September 18, 2026 14:20
a4b7957 to
d6ca887
Compare
stevekaliski-stripe
requested review from
bytaesu and
jlau-stripe
and removed request for
bytaesu
September 18, 2026 14:38
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com> Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
stevekaliski-stripe
force-pushed
the
stevekaliski-better-auth
branch
from
September 18, 2026 20:03
d6ca887 to
5698d26
Compare
kreese-stripe
approved these changes
Sep 21, 2026
|
@stevekaliski-stripe I created a temporary PR targeting the current branch, using our existing way of writing the plugin while making it structurally cleaner and easier to extend. Could you take a look and let me know if anything is unclear? #355 |
bytaesu
reviewed
Sep 21, 2026
Comment on lines
+26
to
+39
| getActions: ($fetch) => ({ | ||
| link: { | ||
| connect: <Throw extends boolean = false>( | ||
| options: LinkConnectOptions = {}, | ||
| fetchOptions?: Omit<BetterFetchOption, 'throw'> & { throw?: Throw }, | ||
| ) => | ||
| $fetch('/link-social', { | ||
| ...fetchOptions, | ||
| throw: fetchOptions?.throw ?? false, | ||
| method: 'POST', | ||
| body: { ...options, provider: 'link' }, | ||
| }) as Promise<LinkConnectResult<Throw>>, | ||
| }, | ||
| }), |
There was a problem hiding this comment.
For context, using a client action would make the endpoint accessible only through authClient, so it may not be the cleanest fit here.
For my proposal, please refer to the implementation in my previous comment 🤓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.