loopback auth treats User.email case sensitive

[Morriz]

And it goes the same for User.username, but that depends on taste...

My use case: I can't login when my iOS automatically sets the first character to uppercase...but please look beyond this ;)

[esco]

It looks like the findOne query that searches by username or email isn't case sensitive

loopback/common/models/user.js

Lines 196 to 203 in 1cabd74

	if (!query.email && !query.username) {
	var err2 = new Error('username or email is required');
	err2.statusCode = 400;
	err2.code = 'USERNAME_EMAIL_REQUIRED';
	return fn(err2);
	}
	self.findOne({where: query}, function(err, user) {

@raymondfeng is it possible to do a case-insensitive query?

[slonoed]

@Morriz, maybe good way to set autocapitalize="off" to your input.

[Morriz]

Sure, that would be handy as well, but is not a solution to the (bigger) problem :)

On 06 Apr 2015, at 21:16, Dmitry Manannikov notifications@github.com wrote:

@Morriz, maybe good way to set autocapitalize="off" to your input.

—
Reply to this email directly or view it on GitHub.

[slonoed]

@Morriz, what problem?

In rfc2821

The local-part of a mailbox MUST BE treated as case sensitive.

If you need case insensitive emails, you can use beforeRemote hook to change it on login and sign up.

[esco]

@slonoed @Morriz

That quote is not referring to email addresses.

Case-insensitive emails make a lot of sense. Imagine if gmail addresses were case-sensitive, there would be so much confusion. Github also does case-insensitive email login.

[Morriz]

Like I said it in the title: emails were not treated case insensitive when I said that. It does now?

On 06 Apr 2015, at 21:53, Esco Obong notifications@github.com wrote:

@slonoed @Morriz

That quote is not referring to email addresses.

Case-insensitive emails make a lot of sense. Imagine if gmail addresses were case-sensitive, there would be so much confusion. Github also does case-insensitive email login.

—
Reply to this email directly or view it on GitHub.

[Morriz]

Ha, I always thought emails were treated case insensitive. Learned something new today ;)

On 06 Apr 2015, at 21:34, Dmitry Manannikov notifications@github.com wrote:

@Morriz, what problem?

In rfc2821

The local-part of a mailbox MUST BE treated as case sensitive.
If you need case insensitive emails, you can use beforeRemote hook to change it on login and sign up.

—
Reply to this email directly or view it on GitHub.

[slonoed]

@esco, I agree with you. Almost all mail services use case insensitive. But include it to loopback by default – bad idea. Loopback provide ability (with few lines of code) to make email insensitive. This is enough.

[esco]

@slonoed fair enough that its flexible, but my vote is for the most common use case to be the default with the ability to make it case-sensitive. 👍

[Morriz]

I agree, it's value (i.e. supporting majority of well known use cases) I am after mostly, and I bet most ppl are...

On 06 Apr 2015, at 22:35, Esco Obong notifications@github.com wrote:

@slonoed fair enough that its flexible, but my vote is for the most common use case to be the default with the ability to make it case-sensitive.

—
Reply to this email directly or view it on GitHub.

[slonoed]

Supporting majority well known use cases must be in new versions of specs. And after supporting in code. When software developers build soft based on use cases instead of specs, they build new internet explorer. Nah..

[esco]

@slonoed sometimes being pragmatic is good. This would cover 99% of use cases. Case-sensitive email lookups aren't very useful.

[technicallyfeasible]

+1

I agree to supporting the most common usecase. No service I know of treats emails as case sensitive and if they do it leads to a lot of confusion with seemingly not being able to login.
I got infuriated by such behavior myself on several occasions.

[slonoed]

@technicallyfeasible why you got infuriated? You read email specs?

[technicallyfeasible]

@slonoed Yes, I know the specs, I have implemented an email parser myself once but have you tried to explain that to a potential user? They usually just move on to the service that is more accommodating.