adding additional check of string for case insentive emails

[geekguy]

Issue:

This line doesn't work when we have caseSensitiveEmail set to false and we make queries like,

User.findOne({where: {email: {inq: ["hello@test.com"]}}})

Additional check for string is required.

[slnode]

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

[slnode]

Can one of the admins verify this patch?

[slnode]

Can one of the admins verify this patch?

[slnode]

Can one of the admins verify this patch?

[slnode]

Can one of the admins verify this patch?

[davidcheung]

@geekguy thanks for your contribution! would you be able to add a test case to prevent regression on this fix?

[slnode]

Can one of the admins verify this patch?

[slnode]

Can one of the admins verify this patch?

[slnode]

Can one of the admins verify this patch?

[slnode]

Can one of the admins verify this patch?

[bajtos]

@slnode ok to test

[bajtos]

@geekguy thank you for the pull request. As @davidcheung already mentioned, we need a unit test to verify your change.

BTW while the solution proposed here is a good short-term fix, for long term we should improve this code to correctly convert email values to lower case even for complex queries like the one shown above.

User.findOne({where: {email: {inq: ["HELLO@test.com"]}}})
// should be converted to
{where: {email: {inq: ["hello@test.com"]}}}

[geekguy]

@bajtos : Can you please point me to a file where I should add test cases ?

I ll also check regarding converting complex queries to lower case.

[davidcheung]

@geekguy perhaps like this test case, but instead of using the returned object, it makes another call using the where-inq query, then assert the object returned?

[davidcheung]

fixes #2522

[bajtos]

@geekguy Can you please point me to a file where I should add test cases ?

Sure. You can start by looking at #1804 which added the "access" hook and a test suite describe('Access-hook for queries with email NOT case-sensitive'), see

loopback/test/user.test.js

Lines 437 to 457 in ed76a34

	describe('Access-hook for queries with email NOT case-sensitive', function() {
	it('Should not throw an error if the query does not contain {where: }', function(done) {
	User.find({}, function(err) {
	if (err) done(err);
	done();
	});
	});
	it('Should be able to find lowercase email with mixed-case email query', function(done) {
	User.settings.caseSensitiveEmail = false;
	User.find({ where: { email: validMixedCaseEmailCredentials.email }}, function(err, result) {
	if (err) done(err);
	assert(result[0], 'The query did not find the user');
	assert.equal(result[0].email, validCredentialsEmail);
	done();
	});
	});
	});

[davidcheung]

taking over to rebase + add tests @geekguy on #2912
cc/ @bajtos