Skip to content

Test cases for turbulence model variants - #1418

Merged
pcarruscag merged 10 commits into
developfrom
feature_turbmod_variants_testcases
Nov 6, 2021
Merged

Test cases for turbulence model variants#1418
pcarruscag merged 10 commits into
developfrom
feature_turbmod_variants_testcases

Conversation

@suargi

@suargi suargi commented Nov 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull request description

This pull request introduces a series of regression cases for the Spalart-Allmaras turbulence model variations and corrections:

  • Baseline
  • Negative
  • Edwards
  • Compressibility
  • Compressibility and Edwards
  • QCR2000

The residuals on the python scripts are wrong. These values are temporary and will be updated once the regression tests are run on the Travis CI system.
Since this pull request does not introduce any code modification, the residuals on the python scripts have been updated on commit 1a1661f with the Travis Cl (sim_vals (computed)) values.

Related Work

These tests will be further used to verify the correct implementation of #1413

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

suargi added 2 commits November 2, 2021 08:54
@suargi
Test cases for Spalart-Allmaras turbulence model variations and corre…
da60eb0 
…ctions
@suargi
Better appearance of python scripts
f01f78b 
Modified the serial_regression.py and parallel_regression.py for a better looking
@pr-triage pr-triage Bot added the PR: draft label Nov 2, 2021
@suargi

suargi commented Nov 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

As stated in #1384 some hybrid parallel AD regression tests failed.
The regression test visc_cone has also failed with ERROR: The code was not able to get to the "Begin solver" section. for both serial_regression.py and parallel_regression.py.

@suargi suargi removed the PR: draft label Nov 2, 2021
@suargi suargi changed the title [WIP] Feature turbmod variants testcases Feature turbmod variants testcases Nov 2, 2021
@pr-triage pr-triage Bot added the PR: draft label Nov 2, 2021
@WallyMaier

WallyMaier commented Nov 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

@suargi An update to the TestCases repo renamed a folder for the visc_cone. I have a PR open to fix the problem ---> Should be fixed now.

@suargi

suargi commented Nov 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@suargi An update to the TestCases repo renamed a folder for the visc_cone. I have a PR open to fix the problem ---> Should be fixed now.

Thanks @WallyMaier. Now serial and parallel regression test work smoothly.

@suargi suargi removed the PR: draft label Nov 3, 2021
@suargi
suargi marked this pull request as ready for review November 3, 2021 09:00
@pcarruscag pcarruscag changed the title Feature turbmod variants testcases Test cases for turbulence model variants Nov 3, 2021
pcarruscag
pcarruscag reviewed Nov 3, 2021
View reviewed changes

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍
Please strip all the comments and non relevant options from the configs.

Comment thread TestCases/serial_regression.py Outdated
Comment thread TestCases/turbulence_models/sa/rae2822/turb_SA_COMP_EDW_RAE2822.cfg
OUTPUT_WRT_FREQ= 250
%
% Screen output fields
SCREEN_OUTPUT= (INNER_ITER, RMS_DENSITY, RMS_MOMENTUM-X, RMS_MOMENTUM-Y, RMS_NU_TILDE, LIFT, DRAG)

@pcarruscag pcarruscag Nov 2, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread TestCases/turbulence_models/sa/rae2822/turb_SA_BSL_RAE2822.cfg
Comment thread TestCases/turbulence_models/sa/rae2822/turb_SA_BSL_RAE2822.cfg Outdated
Comment thread TestCases/turbulence_models/sa/rae2822/turb_SA_BSL_RAE2822.cfg Outdated
Comment thread TestCases/turbulence_models/sa/rae2822/turb_SA_BSL_RAE2822.cfg Outdated
@suargi
Update serial_regression.py and turbulence models regression tests co…
84c9584 
…nfig files

Remove the turbulence models serial regression tests. Left only parallel tests.
Strip all the comments and non relevant options from the config files
@suargi

suargi commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for this +1 Please strip all the comments and non relevant options from the configs.

Thank you Pedro for all your suggestions.
I have reverted the serial_regression.py file and updated the configuration files. This work is done in 84c9584.

WallyMaier
WallyMaier reviewed Nov 3, 2021
View reviewed changes
Comment thread TestCases/turbulence_models/sa/rae2822/turb_SA_COMP_EDW_RAE2822.cfg Outdated
pcarruscag
pcarruscag reviewed Nov 4, 2021
View reviewed changes
Comment thread TestCases/parallel_regression.py Outdated
Comment thread TestCases/parallel_regression.py Outdated
Comment thread TestCases/parallel_regression.py Outdated
Comment thread TestCases/parallel_regression.py Outdated
Comment thread TestCases/parallel_regression.py Outdated
Comment thread TestCases/parallel_regression.py Outdated
@suargi
Remove config files header info
6bf7b7d 
Remove the configiguration file header info: case description, author, institution and date
@pcarruscag
pcarruscag merged commit 147dfac into develop Nov 6, 2021
@pcarruscag
pcarruscag deleted the feature_turbmod_variants_testcases branch November 6, 2021 22:14
@suargi suargi mentioned this pull request Nov 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WallyMaier WallyMaier WallyMaier left review comments
@pcarruscag pcarruscag pcarruscag approved these changes

Assignees

No one assigned

Labels

changelog:chore PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suargi @WallyMaier @pcarruscag