[WIP] Multizone discrete adjoints for turbomachinery - #2317
[WIP] Multizone discrete adjoints for turbomachinery#2317oleburghardt wants to merge 35 commits into
Conversation
|
|
||
| su2double gammaIn_BC = 0; | ||
| if (nDim == 3){ | ||
| gammaIn_BC = FlowDir[2]; //atan(FlowDir[2]/FlowDir[0]); |
Check notice
Code scanning / CodeQL
Commented-out code
|
@joshkellyjak @pcarruscag Should I make some first commits for a "tag type / debug" recording to this branch? (This problem is the main motivation but technically it's quite unrelated.) We need it here, but it might be better to merge it from a dedicated branch. |
…l write restart files during runtime (there is a bug, potentially when clearing the tape).
Personally I would like this to selfishly enhance my understanding, but I don't think it should be merged when we complete the PR. Could be useful documentation for the website. |
Well I think the functionality should be merged at some point. It might become too much for this PR(?). Let me just go ahead and create a dedicated branch for the tag tape. We could just use that branch as a helper then and prepare it for develop after this one is merged. |
|
Ah now I got the comment. I would keep adding the debug tape separate from fixing the turbo issues |
…zation.hpp (to cover RealReverseTag).
|
Reverting an accidental merge |
…his is a temporary change to avoid false positives when a tag tape is used. They might be unnecessary anyway though.
Check notice
Code scanning / CodeQL
Long switch case
## Proposed Changes This is a cleaned up PR of the fixes needed for multizone adjoints for turbomachinery from the previous PR of @oleburghardt and I's work. This PR refactors the mixing plane implementation and some of the turbo specific features to make them tape consistent. ## Related Work Now closed PR #2317 ## PR Checklist *Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.* - [ X ] I am submitting my contribution to the develop branch. - [x] My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson). - [x] My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/). - [x] I used the pre-commit hook to prevent dirty commits and used `pre-commit run --all` to format old commits. - [x] I have added a test case that demonstrates my contribution, if necessary. - [x] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary. --------- Co-authored-by: Joshua Kelly <j.a.kelly@tudelft.nl> Co-authored-by: Josh Kelly <J.Kelly7@liv.ac.uk> Co-authored-by: Ole Burghardt <ole.burghardt@scicomp.uni-kl.de> Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Continued by #2446.
Original Message
This is, for now, a brief note on @joshkellyjak 's and my WIP on a discrete adjoint functionality for multizone (multi-stage, multi-row) turbomachinery cases. We intend to realize everything through the native multizone discrete adjoint solver, though some turbo-specific problems need to be resolved.
This will, probably, involve further additions/corrections/cleanups around the mixing plane interface so that it is recorded properly. The current recording seems to still be not fully correct.