Restructure CVariable files - #725
Conversation
| ../../Common/src/toolboxes/MMS/libSU2_a-CUserDefinedSolution.o | ||
| ___bin_SU2_DEF_LDADD = \ | ||
| ../../SU2_CFD/obj/libSU2Core.a \ | ||
| ../../Common/lib/libSU2.a |
There was a problem hiding this comment.
Is there any reason to link against individual object files instead of the static library?
There was a problem hiding this comment.
Actually there is no reason 👍 Thanks!
There was a problem hiding this comment.
agreed.. I think that's just legacy behavior from before the libSU2Core.a was added around the time of the in-memory python wrapper
| ../../Common/src/toolboxes/MMS/libSU2_a-CUserDefinedSolution.o | ||
| ___bin_SU2_DEF_LDADD = \ | ||
| ../../SU2_CFD/obj/libSU2Core.a \ | ||
| ../../Common/lib/libSU2.a |
There was a problem hiding this comment.
agreed.. I think that's just legacy behavior from before the libSU2Core.a was added around the time of the in-memory python wrapper
| @@ -0,0 +1,150 @@ | |||
| /*! | |||
| * \file CAdjEulerVariable.hpp | |||
There was a problem hiding this comment.
Looks like you are already doing it, but this is a nice opportunity to fix any indentation / white space / line ending issues when creating these new files. Can you please double check?
There was a problem hiding this comment.
I think indentation was already ok, I striped all trailing white spaces now.
There are also many (many...) comments that were copied and do not match the function, that is not a huge deal since these methods explain themselves. I fixed some but I will not fix all of them...
There was a problem hiding this comment.
Certainly not expected that you fix them all.. let's get some help on that in a later sweep once merged.
Thanks for the clean up! Can you also verify that all line endings are linux style and not windows format?
There was a problem hiding this comment.
Apparently everything was LF-ended already, at least the IDE I use did not pick up anything.
talbring
left a comment
There was a problem hiding this comment.
Thanks @pcarruscag! Just went through all the changes and I have nothing to complain. Lets continue with this restructuring ... I think it will really help with the readability and maintenance.
|
Thanks @talbring. You were right about the includes, even for these classes with lots of inlines everything seems to work fine if only the "client" solver includes the classes it uses. |
Proposed Changes
Breakup CVariable classes into individual hpp and cpp files, with inlines defined in hpp.
Revise the includes of client classes (CSolver and derived).
Related Work
Addresses part of #583
Preparation for #716
PR Checklist