Skip to content

Various fixes II - #807

Merged
pcarruscag merged 17 commits into
developfrom
various_fixes_II
Nov 6, 2019
Merged

Various fixes II#807
pcarruscag merged 17 commits into
developfrom
various_fixes_II

Conversation

@oleburghardt

@oleburghardt oleburghardt commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

Proposed Changes

This is a follow-up of #798 for minor changes.
Feel free to add bug fixes and similar for problems that you might came across during testing.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.

@oleburghardt oleburghardt changed the title Remove old CHT test case that was replaced by an up-to-date one and r… Various fixes II Oct 29, 2019
@oleburghardt

Copy link
Copy Markdown
Contributor Author

@pcarruscag
Maybe you can add the fix for the issue that you brought up this morning to this branch?

@WallyMaier

Copy link
Copy Markdown
Contributor

@oleburghardt I can run through the branch and do some general cleanup (commente, whitespaces and such), unless you think it would be better to in its own branch

@pcarruscag

Copy link
Copy Markdown
Member

@WallyMaier let's keep that for when we move files around, unless you are talking about some completely wrong comments, as it tends to create a lot of merge conflicts.

@WallyMaier

Copy link
Copy Markdown
Contributor

@pcarruscag I was planning to do all, but I can stick to places that files have already been moved around. Is there a list of future restructuring to happen so I can avoid those files?

Version 7 seems to be a good place to tackle a lot of these small changes. In any case, I can address this in a separate branch to limit any downsides.

@pcarruscag

Copy link
Copy Markdown
Member

I have CSolver and CNumerics in mind for restructuring as part of #789 after #790 and #777 are merged.
Maybe you could start with geometry classes (they sure have plenty of formatting issues)? It does not seem like anyone is working on them. I noticed some trailing spaces in the new output structure too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants