Skip to content

Fix bug for incompressible FSI cases. - #897

Merged
rsanfer merged 2 commits into
developfrom
feature_fsi_bugfix
Mar 3, 2020
Merged

rsanfer merged 2 commits into
developfrom
feature_fsi_bugfix

Conversation

@rsanfer

@rsanfer rsanfer commented Mar 3, 2020

Copy link
Copy Markdown
Contributor

Proposed Changes

Fixes a bug introduced in #756 for incompressible FSI cases.

Related Work

This kind of bugs could be avoided with a strategy as suggested by @pcarruscag in #770

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@rsanfer
rsanfer requested a review from talbring March 3, 2020 14:30
@rsanfer

rsanfer commented Mar 3, 2020

Copy link
Copy Markdown
Contributor Author

I don't know where this extra commit from github actions comes from. @talbring ??

@talbring
talbring force-pushed the feature_fsi_bugfix branch from 0e042b5 to 3908bfd Compare March 3, 2020 14:49
@talbring

talbring commented Mar 3, 2020

Copy link
Copy Markdown
Member

Sorry, apparently there is a "bug" in the github actions system ... should work now.

@talbring

talbring commented Mar 3, 2020

Copy link
Copy Markdown
Member

I did a force push, so you have to delete your local branch and fetch the new one in case you want to modify it locally.

@rsanfer

rsanfer commented Mar 3, 2020

Copy link
Copy Markdown
Contributor Author

Tests are passing, so this wasn't covered. I will make sure it's covered via the tutorials.

@pcarruscag pcarruscag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants