Fix bug for incompressible FSI cases. - #897
Merged
Merged
Conversation
Contributor
Author
|
I don't know where this extra commit from github actions comes from. @talbring ?? |
talbring
force-pushed
the
feature_fsi_bugfix
branch
from
March 3, 2020 14:49
0e042b5 to
3908bfd
Compare
Member
|
Sorry, apparently there is a "bug" in the github actions system ... should work now. |
Member
|
I did a force push, so you have to delete your local branch and fetch the new one in case you want to modify it locally. |
Contributor
Author
|
Tests are passing, so this wasn't covered. I will make sure it's covered via the tutorials. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes a bug introduced in #756 for incompressible FSI cases.
Related Work
This kind of bugs could be avoided with a strategy as suggested by @pcarruscag in #770
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.