V&V M5 SWBLI - #77
Merged
Merged
Conversation
TobiKattmann
left a comment
Contributor
There was a problem hiding this comment.
I guess this is WIP but anyway. Thanks for working on this vandv addition 💐
Please make sure to draw a clear distinction between what is available in the regression tests and what results you produced for this validation case. On the first read I was a bit confused tbh
And maybe just a note on whether you made any changes (beyond the obvious limiter and convective scheme switches) between cases, especially for the refined version.
Comment on lines
+41
to
+42
| Given the focus of this validation case (interaction between a shock and a boundary layer) it is of particular interest to analyze how well CFD predicts the | ||
|
|
Contributor
There was a problem hiding this comment.
it is of particular interest to analyze how well CFD predicts the ... the suspense is killing me 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.