Skip to content

Fix logo size in GitHub template #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frm wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix logo size in GitHub template #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion github/templates/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,6 @@ About

PROJECT_NAME is maintained by [Subvisual](http://subvisual.com).

[![Subvisual](https://github.com/ghraw/subvisual/guides/master/github/templates/logos/blue@4x.png)](http://subvisual.com)
[<img alt="Subvisual logo" src="https://github.com/ghraw/subvisual/guides/master/github/templates/logos/blue@8x.png" width="350px" />](https://subvisual.com)

@pfac pfac Feb 21, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to MDN, the width attribute must be an integer without a unit.
  • If you check the resulting markup on GitHub, the style attribute is defined to set max-width: 100%. So ideally max-width should be set in the style attribute, overriding their value.
  • Using the 8x image version seems rather odd. Instinctively it seems to me to be overkill to load such a big image just for a README. Also, you changed the subvisual_logo_with_name.png file because that's what being used in most repos. Why not simply use that file in the template?
  • Given GitHub automatically sets the image to fill the available space at most, have you considered instead just putting a <div style="max-width: 350px"> around the image?

@frm frm May 11, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put HTML in the READMEs?

@pfac pfac May 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Markdown spec supports plain HTML. You just can't use Markdown inside an HTML tag that way, but you can use any HTML snippet you want and it will be untouched (supposedly) in the end result.

@frm frm May 11, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the Markdown spec supports plain HTML, I just think you can't do a lot on Github Markdown. Uh, I'll try later.

Re 8x version: new Mac and iPad screens use that, is there any way we can work around that pixelation?

Re subvisual_logo_with_name.png file name: because older repos, if we change that file to be 2x, 4x or even 8x, would need to be updated or end up with a HYYYUUUUGE logo in the README. Like, occupying almost 100% of the width.

@pfac pfac May 12, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the Markdown spec supports plain HTML, I just think you can't do a lot on Github Markdown. Uh, I'll try later.

Re 8x version: new Mac and iPad screens use that, is there any way we can work around that pixelation?

Re subvisual_logo_with_name.png file name: because older repos, if we change that file to be 2x, 4x or even 8x, would need to be updated or end up with a HYYYUUUUGE logo in the README. Like, occupying almost 100% of the width.

Is there any pixelation, or are you assuming? Just asking, because changing to a smaller logo the README assumes the new logo dimensions. So using the 1x logo in a high pixel density device should just show it smaller I reckon. Might be too small though, but I believe the 8x would be overkill unless we actually need to.

@frm frm May 12, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any pixelation, or are you assuming?

I'll have to take a crack at this because this is from February and I don't quite recall what happened. I'll check in later I guess.


If you need to contact the maintainer, you may <a href="mailto:contact@subvisual.com">reach out to us</a> or use [this](https://trello.com/b/svB6ZSce/areas-of-responsability-dris) Trello board.
Binary file modified github/templates/subvisual_logo_with_name.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.