Address unexpected_cfgs warnings - #115
Merged
Merged
Conversation
Contributor
Author
|
@sunfishcode Any idea on what might be the cause of those tests failure? |
Owner
|
It looks like updating to nightly-2024-05-18 breaks the trick that the |
Owner
|
I'm experimenting with #116 as a possible fix for this issue. |
Owner
|
I've now merged #116, which should fix the failures on Rust nightly. Would you mind rebasing on that? |
Contributor
Author
|
Not at all. Rebased. |
Owner
|
Thanks! |
Owner
|
This is now released in origin 0.18.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates to the latest nightly and address all the
unexpected_cfgswarnings, I could find.Namely it:
docsrsinstead ofdoc_cfg, since the former is standardtarget_env = "gnueabi"condition since no target uses itFixes #114
r? @sunfishcode