Skip to content

Fix machine list wrapping in narrow terminals - #5107

Merged
tomr-a5 merged 2 commits into
masterfrom
tom/fix-machine-list-wrapping
Aug 21, 2026
Merged

Fix machine list wrapping in narrow terminals#5107
tomr-a5 merged 2 commits into
masterfrom
tom/fix-machine-list-wrapping

Conversation

@tomr-a5

@tomr-a5 tomr-a5 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

What changes

fly machine list pages an oversized interactive table horizontally instead of allowing the terminal to soft-wrap its rows. The pager explains how to scroll and quit while keeping all thirteen columns and full values available.

Scope

Redirected, JSON, and quiet output remain unchanged. Tables that fit the terminal and other commands do not page. A missing or disabled pager falls back to the existing raw table, and shared table rendering defaults do not change.

Testing

  • go test ./... -count=1
  • go test -race ./internal/command/machine ./iostreams -count=1
  • A real less pseudo-terminal check at 120 columns verified the prompt, UTF-8 separators, horizontal navigation through the final Size column, and clean exit with q; a 400-column check verified pager bypass.

Fixes #4710.

@tomr-a5 tomr-a5 self-assigned this Aug 20, 2026
@tomr-a5
tomr-a5 marked this pull request as ready for review August 20, 2026 23:33
Copilot AI lite review requested due to automatic review settings August 20, 2026 23:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@tomr-a5
tomr-a5 merged commit 0eb5a81 into master Aug 21, 2026
26 of 31 checks passed
@tomr-a5
tomr-a5 deleted the tom/fix-machine-list-wrapping branch August 21, 2026 00:03
tomr-a5 added a commit that referenced this pull request Aug 24, 2026
Revert "Fix machine list wrapping in narrow terminals (#5107)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'fly machine list -a {app}' produces poorly formatted table.

2 participants