use machines api for IP assignments (both ingress and egress) - #5154
Merged
Conversation
lillianberryfly
force-pushed
the
ip-assignments-machines-api
branch
from
September 1, 2026 17:49
c82136b to
0fbda62
Compare
lillianberryfly
force-pushed
the
ip-assignments-machines-api
branch
from
September 1, 2026 17:57
0fbda62 to
09aedbe
Compare
tomr-a5
approved these changes
Sep 1, 2026
tomr-a5
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Only thing I noticed is that we drop organization and network from private v6 allocation in both the postgres launcher and remote builder. Not sure if they still need that but flyctl-wise this looks good to me!
Contributor
Author
|
test failures are caused by GHA, not bad code.
those were unused |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.