Show warning after login if new token is shadowed. - #5173
Merged
Conversation
There's a UX footgun where a user runs `fly auth login` successfully but subsequent commands still fail because an invalid `FLY_API_TOKEN` is set, which takes precedence over the newly obtained token. This PR teaches `fly auth login` to print a warning if either `FLY_API_TOKEN` or `FLY_ACCESS_TOKEN` is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a UX footgun where a user runs
fly auth loginsuccessfully but subsequent commands still fail because an invalidFLY_API_TOKENis set, which takes precedence over the newly obtained token.This PR teaches
fly auth loginto print a warning if eitherFLY_API_TOKENorFLY_ACCESS_TOKENis set.