tp: relax strict upper bound check in TestBackoffBeforeDeadline - #48
Open
Aditya-9-6 wants to merge 1 commit into
Open
Aditya-9-6 wants to merge 1 commit into
Aditya-9-6 wants to merge 1 commit into
Conversation
When execution is fast, remaining time minus pollDeadlineSlack can be exactly 9s, causing �o < 9*time.Second to fail with got 9s. Using <= avoids the flaky boundary failure while preserving the test invariant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
tp/client_test.go,TestBackoffBeforeDeadline/backoff_sleeps_past_deadlinecreates a context with a 10-second timeout:boBeforeDeadlinecomputes:When the test executes rapidly and negligible time has elapsed between context creation and
time.Until(deadline),remainingis 10s andlatestevaluates to exactly9s.Because the assertion checks strict inequality (
bo < 9*time.Second), it intermittently fails with:Solution
Change the upper bound assertion to
assert.True(t, bo <= 9*time.Second, "got %s", bo). This permits the boundary value of10s - 1s = 9swhentime.Until(deadline)has not yet ticked below 10s, while preserving the test invariant thatbois clamped to roughlyremaining - pollDeadlineSlack.