MITM to proxy HTTPS traffic - #34
Closed
igor-ladkin wants to merge 2 commits into
Closed
igor-ladkin wants to merge 2 commits into
igor-ladkin wants to merge 2 commits into
Conversation
Contributor
|
Closing this: since #56, tokenizer refuses CONNECT on purpose as the CONNECT/MITM path let the Host header and the dialed host diverge, which broke allowed_hosts pinning (fixed in v119). Supporting SDKs that only speak HTTPS_PROXY would mean reintroducing CONNECT with the host checks bound to the CONNECT target, which is a design change rather than a rebase. If the need is still live, open an issue describing the SDK and we'll take it up there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoC to route requests through tokenizer server when we don't have full control over HTTP client used in the app (e.g. SDKs, etc.)