Skip to content

chore: remove {@const ...} tags from template - #1110

Merged
jycouet merged 8 commits into
mainfrom
remove-const-tags
Jun 5, 2026
Merged

chore: remove {@const ...} tags from template#1110
jycouet merged 8 commits into
mainfrom
remove-const-tags

Conversation

@Rich-Harris

Copy link
Copy Markdown
Member

Replaces {@const ...} with declaration tags. Tests fail locally for me, not clear why, hoping they pass in CI

@changeset-bot

changeset-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 09f2a4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry Conduitry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue is that we need to bump the devdep version of Svelte that's used in tests. And then also probably ESLint and Prettier plugins.

But also, if we're introducing new Svelte features into the demo apps, we should bump the ranges of the compiler, ESLint, and Prettier plugins that are set in package.json in the various templates.

@Rich-Harris

Copy link
Copy Markdown
Member Author

@jycouet are the test failures expected?

@jycouet

jycouet commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@jycouet are the test failures expected?

Looking at it now its because of minimum age of packages.
I think that we don't whan people to add in their conf non default age neither excludes.

We should probably stick to defaults of 1440 https://pnpm.io/fr/settings#minimumreleaseage ? Today we have https://github.com/sveltejs/cli/blob/main/pnpm-workspace.yaml#L1 (2 days)

Should be soon green. (svelte 5.56.1 will be 48 hours old in 14h 😅)

@jycouet
jycouet force-pushed the remove-const-tags branch from 7e79907 to c849991 Compare June 3, 2026 06:25
@jycouet
jycouet requested a review from Conduitry June 4, 2026 07:03
@jycouet
jycouet dismissed Conduitry’s stale review June 5, 2026 18:25

All deps are now bumped

@jycouet
jycouet merged commit 8af3c60 into main Jun 5, 2026
5 of 6 checks passed
@jycouet
jycouet deleted the remove-const-tags branch June 5, 2026 18:25
@github-actions github-actions Bot mentioned this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants